Pass attrs directly to AttributesIterator instead of validator#2665
Merged
ericproulx merged 1 commit intomasterfrom Mar 12, 2026
Merged
Pass attrs directly to AttributesIterator instead of validator#2665ericproulx merged 1 commit intomasterfrom
ericproulx merged 1 commit intomasterfrom
Conversation
Danger ReportNo issues found. |
ericproulx
added a commit
that referenced
this pull request
Mar 9, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ericproulx
force-pushed
the
refactor/attrs_iterator
branch
from
a7e8bd2 to
4942e8e
Compare
dblock
approved these changes
Mar 11, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ericproulx
force-pushed
the
refactor/attrs_iterator
branch
from
4942e8e to
78b7113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributesIterator#initializeto acceptattrsdirectly instead of avalidatorobjectattrsparameter fromyield_attributessignatures; subclasses access@attrsdirectlyBase#validate!,DefaultValidator#validate!,MultipleParamsBase#validate!)SingleAttributeIteratorspec accordingly🤖 Generated with Claude Code