Fix command injection#13
Merged
Merged
Conversation
All pdftk invocations were built by string interpolation and run via
%x{}, so file names containing shell metacharacters were interpreted
by the shell - command injection whenever an application passes
user-controlled paths.
Switch to Open3.capture2e with array arguments, which spawns pdftk
directly without any shell:
- call_pdftk now passes its arguments to the process verbatim;
callers no longer need (or want) to quote paths
- cat keeps its documented wildcard support by expanding globs with
Dir.glob instead of relying on the shell
- encrypt_options strings are tokenized with Shellwords.split to
preserve the old word-splitting behaviour
- PdftkError messages still show a copy-pasteable command line,
rendered with Shellwords.join
Adds a regression test filling a form whose destination is
'weird $(touch hacked); name.pdf' and asserting the name is treated
literally and nothing executes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.