Canonicalize preloads to save memory and fix broken preload#7
Open
jhawthorn wants to merge 2 commits into
Open
Canonicalize preloads to save memory and fix broken preload#7jhawthorn wants to merge 2 commits into
jhawthorn wants to merge 2 commits into
Conversation
Previously the test for https://w3id.org/bundle/context passed, however that preload was misconfigured and didn't work. Using webmock and a real call to parse we can ensure that the configuration is correct and that the preloading works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regenerates the files using ruby-rdf/json-ld#61, with the exception of
lib/json/ld/preloaded/obi.rbwhich I edited by hand (it's not in the Rakefile I guess?).Previously
lib/json/ld/preloaded/research.rbdid not work as it registered under an https URL and then aliased that https URL to itself, which did nothing.JSON::LD::Context#parseonly looks forhttp://preloads. I adjusted the tests to test using webmock so that this type of problem can be detected.This also ends up removing all aliases as they all just seemed to be https vs http or canonicalization changes. Everything other than the
httpand canonicalized version of the URL could never be loaded so they previously had no effect other than preventing the code block from being GC'd.