Skip to content

Add CI testing against Ruby 3.4 and 4.0#65

Open
larouxn wants to merge 1 commit into
ruby-rdf:developfrom
larouxn:add_support_for_ruby_4
Open

Add CI testing against Ruby 3.4 and 4.0#65
larouxn wants to merge 1 commit into
ruby-rdf:developfrom
larouxn:add_support_for_ruby_4

Conversation

@larouxn

@larouxn larouxn commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Proposing we add CI testing against both Ruby 3.4 and 4.0 given ruby-head is now Ruby 4.1. Note, I wasn't sure what to do with the wintests section so I updated it the same but can revert if desired.

Comment thread lib/json/ld/expand.rb Outdated
Comment thread .github/workflows/ci.yml Outdated
@larouxn larouxn force-pushed the add_support_for_ruby_4 branch from 2ceefad to 28b16e9 Compare June 19, 2026 21:36
@larouxn larouxn changed the title Add optimized support for and test against Ruby 4 Add CI testing against Ruby 3.4 and 4.0 Jun 19, 2026
@larouxn

larouxn commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

I believe we need to first do the following before we'll see passing CI here.

Unfortunately, even with both of those changes on a branch, CI is still failing so it's likely an actual issue perhaps in dependencies or code, given Ruby versions and multi_json changes are handled.

https://github.com/larouxn/json-ld/actions/runs/27867108935/job/82472935416

@larouxn

larouxn commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Update, I have gotten CI passing for standard Ruby but doing so required four code level changes. As I'm not familiar with this gem nor RDF, just wanted to migrate from multi_json to json and do a bit of maintenance, I would appreciate some guidance as to what do to do. I can open PRs with the fixes or I'd be fine with a maintainer picking them off my branch (main commit: 14a3525) or doing some other kind of fix. In the end we should just aim to get CI into a passing state.

image

@larouxn larouxn force-pushed the add_support_for_ruby_4 branch from 28b16e9 to 7b3b88f Compare June 22, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants