Use main gemfile for truffleruby/jruby - Fix CI #3844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
truffleruby-jruby-ci-gemfile
branch
2 times, most recently
from
1b79b26 to
9a7a7cc
Compare
Each time they release a new X.Y, the versions in the gemfiles need to be updated in order to not fail CI. The `engine_version` can be removed but at that point might as well just use the main gemfile. During development, the main gemfile should support these two already anyways.
Earlopain
force-pushed
the
truffleruby-jruby-ci-gemfile
branch
from
9a7a7cc to
23b9de6
Compare
Member
|
Very nice! |
Collaborator
Author
|
Yeah, the problem is that the main gemfile doesn't work for all ruby versions. Not sure which versions works but I do know that it's not every single one. It wouldn't be a problem if the lockfile wasn't commited but since it is there has to me at least more than one gemfile. They don't make much trouble so it shouldn't really matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truffleruby 33.0.0 has been released.
Each time truffleruby/jruby release a new X.Y, the versions in the gemfiles need to be updated in order to not fail CI.
The
engine_versioncan be removed but at that point might as well just use the main gemfile.During development, the main gemfile should support these two already anyways. I moved
parser/ruby_parserout of the platform check. The engine-specific gemfiles installed them but not the main one.