Fix crash when duplicating a dev dependency in Gemfile & gemspec#7215
Merged
Conversation
martinemde
approved these changes
Dec 1, 2023
deivid-rodriguez
force-pushed
the
fix-dup-dev-dependencies-crash
branch
from
db87eb1 to
f24b079
Compare
deivid-rodriguez
force-pushed
the
fix-dup-dev-dependencies-crash
branch
from
f24b079 to
e78c0a4
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We recently started warning duplicated development dependencies in Gemfile & gemspec with different requirements in #6014.
However, that caused a regression when overriding the dependency source from the gemspec in the Gemfile would no longer work.
What is your fix for the problem, implemented in this PR?
The fix is to prefer the Gemfile dependency and don't warn.
Fixes #6014 (comment).
Make sure the following tasks are checked