Update regex to get the version#293
Merged
Merged
Conversation
If there is any output while loading `.zshrc`, TypeProf will not start because it cannot get the version. In my use case, I was loading `.iterm2_shell_integration.zsh` in the `.zshrc`. refs: https://github.com/gnachman/iTerm2/blob/v3.5.13/Resources/shell_integration/iterm2_shell_integration.zsh To avoid this problem, remove the `^` from the regular expression. I think it is enough to check the end of the output with `$`.
Member
|
Alright, I'll merge it! |
sinsoku
commented
May 1, 2025
| const str = output.trim(); | ||
| log(`typeprof version: ${str}`); | ||
| const version = /^typeprof (\d+.\d+.\d+)$/.exec(str); | ||
| const version = /typeprof (\d+.\d+.\d+)$/m.exec(str); |
Contributor
Author
There was a problem hiding this comment.
Oops, I included this /m flag by mistake.
It is unnecessary and will be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is any output while loading
.zshrc, TypeProf will not start because it cannot get the version.In my use case, I was loading .iterm2_shell_integration.zsh in the
.zshrc.To avoid this problem, remove the
^from the regular expression.I think it is enough to check the end of the output with
$.