Skip to content

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jan 27, 2026

In order to avoid decpreation warnings when running rbs on newer versions of Ruby.

/home/runner/work/webrick/webrick/vendor/bundle/ruby/4.1.0+1/gems/rbs-3.10.2/lib/rbs.rb:11: warning: tsort used to be loaded from the standard library, but is not part of the default gems since Ruby 4.1.0.
You can add tsort to your Gemfile or gemspec to fix this error.

EDIT: Another solution could be "fix and release a new rbs which does this".

In order to avoid decpreation warnings when running rbs on newer versions of Ruby.
@hsbt hsbt merged commit 4509861 into ruby:master Jan 27, 2026
21 checks passed
@olleolleolle olleolleolle deleted the add-tsort-for-ruby-410 branch January 27, 2026 12:44
@jeremyevans
Copy link
Contributor

This change seems odd to me. I'm not against it, but I would think that the correct fix is for rbs to add a dependency on tsort, so gems using rbs don't need an explicit dependency like this on tsort. Otherwise, everything using rbs would have to have a similar change, and that seems undesirable. Better to fix the issue in one place than many places. However, maybe there is a reason that would not work?

@olleolleolle
Copy link
Contributor Author

@jeremyevans No reason, rbs to fix the issue is the next and logical step. This PR can be reverted after such a change has been made. I poked someone in the rbs project that had an open PR about tsort.

@soutaro soutaro mentioned this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants