Use Promise in example for #evaluate_async#325
Open
ttilberg wants to merge 1 commit intorubycdp:mainfrom
Open
Conversation
Member
|
I don't like current API either, but I remember picking up the names for browser.evaluate_async '__f(arguments)', 5, "arg 1", 2, 3is so unreadable. I'm always confused when to put what, and use specs to remember how to use it. So maybe it's time to improve the API then if it's doable at all? :) |
|
Reminding about this PR because I just also was confused by |
goulvench
added a commit
to betagouv/acces-cible
that referenced
this pull request
Mar 13, 2025
See rubycdp/ferrum#325 Co-authored-by: Stéphane Maniaci <stephane.maniaci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #234
I couldn't remember how to get a value back from
evaluate_asyncand remembered I had created an example in a previous issue.The existing example leverages
arguments[0]and calls a simple object. Instead, I would like to see an actual, practical example using familiar things that people would commonly use this for.Additionally, I think we should encourage usage of
__f()as in the next example, instead ofarguments[0], or rework the#evaluate_asynctemplate. As an example, if you call:arguments[0]no longer refers to the fulfill callback. You end up receivingTypeError: arguments[0] is not a function (Ferrum::JavaScriptError).Perhaps this highlights some tweaks that could be made to
evaluate_async, but for now, I'd like to get this docs change up asap.