Skip to content

Lidarr Integration#650

Open
lukasmcd wants to merge 46 commits into
ruddarr:developfrom
lukasmcd:lidarr
Open

Lidarr Integration#650
lukasmcd wants to merge 46 commits into
ruddarr:developfrom
lukasmcd:lidarr

Conversation

@lukasmcd
Copy link
Copy Markdown

Long time user of the add and wanted to contribute something so I've added in Lidarr support to enable music library management using the same stylistic choices of the Radarr/Sonarr integrations.

Changes:

  • Lidarr added as a new instance type
  • New Artists tab to support: searching for artists, artist grid/list, artist details, album details, track details
  • Calendar integration has been added for albums
  • Integration into the Activity tab
  • Added the deep links for the Artists tab
  • Siri Shortcut integration for search for an artist
  • Moves the Settings to the toolbar across all pages on iOS/iPadOS to avoid the automatic "More" tab in the tar bar putting the settings into a sheet (Open to feedback on this specifically as I felt it was the neatest way to handle it)

I've conducted various testing across the new functionality and patched as many bugs as I could find, but like all software there's bound to be a pesky bug lurking somewhere. Also created an additional PR on the apns repo to integrate the web hook notifications from there.

Lidarr.Demo.mov

tillkruss and others added 30 commits April 20, 2024 08:58
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
…ng on finalising data related structs first
@tillkruss
Copy link
Copy Markdown
Collaborator

@lukasmcd Thanks for submitting this. Two things we'll discuss with this.

I don't use Lidarr and this will add ~10,000 new lines of code that need to be maintained by someone that's not me. Future PRs, keeping up-to-date with upstream Lidarr changes, support in Discord, etc. Is that something you want to take on for the next 5 years?

Secondly, the settings in the top navbar sucks UX wise IMO, we'd need a better design for this.

Happy to chat more real-time in Discord if needed.

@lukasmcd
Copy link
Copy Markdown
Author

@tillkruss in terms of support and updates this should be a relatively easy service to support. The Lidarr API has remained quite stable for the last few years since the tool is a little more neglected than Sonarr/Radarr.

Happy to discuss supporting this code though.

For the settings UX, I kind of expected this. Thought it was a quick placeholder to leave for discussion.

I've just joined the Discord server, will reach out to try and find a time that we might be able to chat in depth about this stuff there 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants