Lidarr Integration#650
Conversation
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
Signed-off-by: Till Krüss <tillkruss@users.noreply.github.com>
…ng on finalising data related structs first
…uild underlying album views still
…and bug fixes to come. Settings has been moved from the tab bar to the toolbar
…ditional track file rows
Signed-off-by: Lukas McDiarmid <5728443+lukasmcd@users.noreply.github.com>
|
@lukasmcd Thanks for submitting this. Two things we'll discuss with this. I don't use Lidarr and this will add ~10,000 new lines of code that need to be maintained by someone that's not me. Future PRs, keeping up-to-date with upstream Lidarr changes, support in Discord, etc. Is that something you want to take on for the next 5 years? Secondly, the settings in the top navbar sucks UX wise IMO, we'd need a better design for this. Happy to chat more real-time in Discord if needed. |
|
@tillkruss in terms of support and updates this should be a relatively easy service to support. The Lidarr API has remained quite stable for the last few years since the tool is a little more neglected than Sonarr/Radarr. Happy to discuss supporting this code though. For the settings UX, I kind of expected this. Thought it was a quick placeholder to leave for discussion. I've just joined the Discord server, will reach out to try and find a time that we might be able to chat in depth about this stuff there 🙂 |
Long time user of the add and wanted to contribute something so I've added in Lidarr support to enable music library management using the same stylistic choices of the Radarr/Sonarr integrations.
Changes:
I've conducted various testing across the new functionality and patched as many bugs as I could find, but like all software there's bound to be a pesky bug lurking somewhere. Also created an additional PR on the apns repo to integrate the web hook notifications from there.
Lidarr.Demo.mov