avm2: Update comment about how FP handles uncaught errors - #24222
Open
kjarosh wants to merge 1 commit into
Open
Conversation
This adds more context to how uncaught exceptions work in FP.
kjarosh
added
A-avm2
| // When tracing is disabled, the error won't get stringified for the | ||
| // second time (which is observable), so to improve compatibility in | ||
| // this regard, we disable this feature when emulating the release mode | ||
| // of FP. |
Member
There was a problem hiding this comment.
Can you mention that tracing and flashlog are the same thing?
| // Flash Player traces uncaught errors (when tracing is enabled). | ||
| // | ||
| // When tracing is enabled, Flash Player will *always* log and stringify | ||
| // the exception twice. |
Member
There was a problem hiding this comment.
Can you move this comment after the comment explaining exception dialogs, to make it clearer that the exception dialog is the source of the first stringification?
| // this regard, we disable this feature when emulating the release mode | ||
| // of FP. | ||
| // | ||
| // There is also the additional behavior of debugger exception dialogs, |
Member
There was a problem hiding this comment.
Could you make it clear that debugger exception dialogs also show up in non-debug FP? As it's written, this comment seems to suggest that they're specific to the debug player.
| // | ||
| // There is also the additional behavior of debugger exception dialogs, | ||
| // and if they are enabled, Flash Player will pause the execution and | ||
| // show the uncaught exception in a popup. If the popups are disabled, |
Member
There was a problem hiding this comment.
Could you
- explain how to disable popups, using "dismiss all", and
- make it clear that this tracing only happens when flashlog is also enabled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds more context to how uncaught exceptions work in FP.
Testing
N/A
Checklist