Polyfilled plugin properties remain configurable - #24312
Open
mincerafter42 wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thanks! Adding a test for this shouldn't be too difficult. See e.g. #20033 how that was done. |
evilpie
added
A-web
Collaborator
|
Looks great. If you could follow the commit style we can merge this.
|
This allows multiple plugin polyfills on the same page.
The typical reason for the properties to be defined a second time would be a second plugin spoofer, but for the sake of small and general tests I'm not putting a plugin spoofer in the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #24311.
This allows additional plugin polyfills or additional code in general (from different scripts or browser extensions) to add to
navigator.plugins,navigator.mimeTypesetc. after Ruffle (or to override the properties in any other way, as they normally can do).Testing
Tests added to
web/packages/selfhosted/test/polyfill/spoofing.Checklist