Added unit tests#283
Conversation
rugk
left a comment
rugk
left a comment
There was a problem hiding this comment.
Hi @atharvarajurkar,
thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃
Did you actually run these tests according to the contribution guidelines? (As these are unfortunately quite hard to run…) If so a screenshot of that would be nice.
But before you do the work, see my other comment, as I assume you can delete the lodash files again. We do not need to test stuff that is already tested.
Anyway, I hope this was a good practice and you've learned unit testing things.
|
|
||
| import isObjectLike from "/common/modules/lodash/isObjectLike.js"; | ||
|
|
||
| describe("common lodash: isObjectLike", function () { |
There was a problem hiding this comment.
That's a very good intent, but I doubt we need to test lodash modules again. They are teted by lodash already and may/are in the future even considered to be dropped: https://github.com/TinyWebEx/AddonTemplate/issues/7
But sure this was a good test to do,
Same goes for the other files. BrowserCommunicationTypes is a thing I would keep, the other ones are kinda redundant.
2 participants
No description provided.