Fix: pos images

[alaa-alsalehi]

https://tasko.rukn.sh/tasko/task/TASK-2026-00481

Summary by CodeRabbit

• Bug Fixes

  • Improved image handling and display in the POS system to ensure proper resolution of attached images

• Chores

  • Version bumped to 0.48.1

[coderabbitai]

Warning

Rate limit exceeded

@alaa-alsalehi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 13 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8abb00d-c339-48c2-a862-90211aa3a5d6

📥 Commits

Reviewing files that changed from the base of the PR and between 5b40461 and 3d6a7a5.

📒 Files selected for processing (1)

• src/pages/POS/POS.vue

📝 Walkthrough

Walkthrough

Version bumped to 0.48.1 in package.json. POS.vue import updated to asynchronously resolve attached image sources via resolveAttachImageSrc, replacing direct image assignment with a resolved value fallback pattern.

Changes

POS Image Resolution & Release

Layer / File(s)	Summary
Release Version Bump package.json	Package version incremented from 0.48.0 to 0.48.1.
POS Image Source Resolution src/pages/POS/POS.vue	Import resolveAttachImageSrc utility. In setItems() method, replace direct item?.image assignment with awaited resolveAttachImageSrc(item.image, this.fyo) call, assigning resolved value or undefined to POSItem.image.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop through images bright and clear,
Attachment sources resolved without fear,
POS items now fetch with async care,
Version bumped—0.48.1's in the air!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix: pos images' is directly related to the main change: resolving POS item images to data URLs in src/pages/POS/POS.vue. It clearly identifies the primary fix in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/POS/POS.vue`:
- Around line 761-769: The current loop awaits resolveAttachImageSrc serially so
one rejection aborts setItems() and causes high latency; instead map over your
source items to create an array of promises that call resolveAttachImageSrc for
each item and attach a per-item .catch(() => undefined) fallback so failures
return undefined rather than throwing, then await Promise.all on that array and
use the resulting images when calling this.items.push (or updating setItems) so
images are resolved in parallel and individual failures don’t break the whole
update; reference resolveAttachImageSrc and the this.items.push/setItems update
when making this change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 681e8678-5bfd-423a-8a3b-5ac94d72c1c2

📥 Commits

Reviewing files that changed from the base of the PR and between d3966ae and 5b40461.

📒 Files selected for processing (2)

• package.json
• src/pages/POS/POS.vue