feat(selection-ring): extract selection ring into dedicated UI pass#175
Merged
Conversation
Extract the selection ring annulus out of the main points fragment shader into its own UI-pass renderer. Annulus-only scope, CPU-driven uniform sizing, type-agnostic uniform layout so POI selection can fold in later. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…n-aligned quad Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Also replace backticks with single quotes in the selection-ring WESL comments. wesl-plugin tokenises backticks regardless of comment context, so a 'static suffix import would fail to parse the shader source. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The selection ring is now drawn by the dedicated selectionRingPass; the points pipeline no longer needs the 'selected' varying, isSelected math, or the fragment-side selection branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The points pipeline bakes a 4× padding into the billboard footprint so the soft glow blends with the textured thumbnail. The previous ring formula multiplied the already-padded sizePx by another 8×, ballooning the halo on zoomed-in galaxies. Halving apparentPxRadius cancels half that padding while leaving the pointSizePx-dominated zoom-out case unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
skymap | 0df84ad | Commit Preview URL Branch Preview URL |
May 20 2026, 12:48 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the plan from #173.
Summary
selectionRingPassat the head ofUI_PASSESdraws a white annulus on the swap-chain after tone-mapselectionRingRenderer(factory closure) owns one pipeline, two UBOs (camera + selection), and one bind groupselectedvarying,isSelected/sizeScalemath, and the 90-line in-shader selection branchcolorFragment.weslshrinks from 224 → ~96 linesNotable changes from the plan
max(pointSizePx, apparentPxRadius) * 8byte-for-byte. Visual testing showed this ballooned on zoomed-in galaxies becauseapparentPxRadiusalready includes a 4× thumbnail-footprint padding. Halved the apparent-radius contribution:max(pointSizePx, apparentPxRadius * 0.5) * 8.?static-imported the shaders).Trade-off accepted
!isSelectedbypass on the points-pipeline invisibility cull. A very faint selected galaxy's disk no longer renders, but the UI ring still does — the selection stays visually marked. (Grill Q1, accepted.)Out of scope (follow-ups)
selectedPackedslot from the points uniform + thepickRenderer.tswrite that fills itTest plan
🤖 Generated with Claude Code