feat(signup): Angular version of signup page using existing backend.#1849
Merged
castaway merged 27 commits intoJun 18, 2026
Conversation
castaway
requested changes
Jun 3, 2026
Original review (geir-signup-screen-review-clean):
- C1: Map getRunboxDomains objects to strings defensively; fix mock shapes
- I1: Clear interval on existing-script error listener
- I2: Add destroyed flag and timer cleanup in ngOnDestroy
- I3: Replace hardcoded hex literals with theme palette tokens
- S1: Remove dead SIGNUP_HCAPTCHA_SITE_KEY env var from gen-env.js
- S3: Clear hCaptchaSiteKey on script failure for accurate error message
- S4: Try/catch around formElement.submit() with state reset
- S5: Nullish-coalescing on getSignupHCaptchaSiteKey response
- S7: Remove dead hidden accountType form field
- S8: Unicode-aware password strength regex (\p{Ll}, \p{Lu})
- S9: Validate account_number query param before binding
- S11: Add afterEach fixture.destroy() and hcaptcha stub cleanup
- S12: Capture hCaptcha render params in Cypress stub
- S13: Two-pass focus selector (Angular-invalid first, native second)
Remediation pass (fix-signup-review-findings):
- N1: Gate submit guard on hCaptchaReady instead of hCaptchaSiteKey
- N2: Remove failed hCaptcha script element on error
- N3: Capture subscriptions and guard async chain on destroyed flag
- N4: Add 15s timeout on script-load polling for ad blocker/CSP scenarios
- N5: Wrap afterEach in try/finally for resilient test cleanup
- Guard destroyed-component state in hcaptcha catch handler (N6) - Resolve paused promise in 'still loading' test to prevent GC leak (N9) - Replace footer gradient hex literals with palette tokens - Consolidate breakpoint padding/width/font-size overrides into clamp() expressions on base rules (35 lines net reduction, 883 -> 844 lines) - Add consolidated review document covering all three review passes
Contributor
|
We should test:
NB: I noticed that the RMM signup page figures out a timezone based on a country var in the page that the Template sets.. so we would need to replicate .. tho given the timezone is not amendable by the user, it could be fully done on the backend (why isnt it amendable by the user?) |
Address review findings: bugs, memory leaks, CSS consolidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean version of #1844 without unrelated support commits.