fix(cc-catalog-svc): accept git smart HTTP paths without .git suffix#124
Merged
Conversation
Platform sobow/gitget calls git ls-remote with repo URLs that omit the .git suffix (matching GitHub/GitLab behavior). Rewrite PATH_INFO to the bare-repo form git http-backend expects so airgap catalog clones work. Co-authored-by: Cursor <cursoragent@cursor.com>
cc-catalog-svc imageTag:
|
cc-catalog-svc imageTag:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitpath suffix (e.g./git/rw-cli-codecollection/info/refsin addition to/git/rw-cli-codecollection.git/info/refs).PATH_INFOto/{slug}.git{rest}before delegating togit http-backend, since bare repos on disk keep the.gitdirectory name.info/refsandgit ls-remoteagainst the no-suffix URL form.Fixes airgap workspace indexing failures where sobow calls
git ls-remoteagainst URLs likehttp://<release>-cc-catalog-svc:8080/git/rw-cli-codecollection(platform normalizes repo URLs by stripping.git, matching GitHub/GitLab behavior).Test plan
poetry run pytest cc-catalog-svc/tests/test_git_http.py -v(10 passed)git ls-remote --heads --tags http://<release>-cc-catalog-svc:8080/git/rw-cli-codecollectionreturns refstask_rebuild_workspace_indexsucceedsMade with Cursor