Return nil from FromString on invalid input instead of panicking#7
Open
SAY-5 wants to merge 1 commit into
Open
Return nil from FromString on invalid input instead of panicking#7SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromStringcallsToRuneArray, which returnsnilfor any input that fails validation, and then immediately indexesarr[0]. So a 13-char string whose characters aren't in the alphabet (e.g.FromString("zzzzzzzzzzzzz")), an empty string, or any wrong-length string panics withindex out of rangeinstead of failing gracefully.This guards the
nilcase and returnsnil, matching the existing// TODO: Throw errorintent inToRuneArray. Added a regression test covering a valid round-trip plus the invalid inputs.Fixes #6