Closed
Conversation
matthiasbeyer
requested changes
Jul 29, 2023
Member
matthiasbeyer
left a comment
matthiasbeyer
left a comment
There was a problem hiding this comment.
Hi! Thanks for continuing!
I am off the grid for approx. The next week, so please expect delays in response.
One question (see review). There might be more, I cannot do in depth reviews now as I am on a train. Either way, thanks again for contributing!
matthiasbeyer
requested changes
Jul 29, 2023
Contributor
|
@matthiasbeyer friendly ping as this PR is getting stale (already conflicts raised). Only one |
Member
|
Yes this needs a rebase for resolving conflicts. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Gura. Closes issue #245