Fix missing support for 128-bit integers #731
Open
+115
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tyranron
force-pushed
the
fix-parsing-into-i128
branch
from
3ca2522 to
f99d86e
Compare
Pull Request Test Coverage Report for Build 21673872770Details
💛 - Coveralls |
tyranron
force-pushed
the
fix-parsing-into-i128
branch
from
f99d86e to
e06fd8c
Compare
tyranron
force-pushed
the
fix-parsing-into-i128
branch
from
e06fd8c to
6981823
Compare
Contributor
Author
|
CI error with failed coverage publishing is not relevant to this PR. Everything else made green. |
epage
reviewed
Feb 4, 2026
Comment on lines
+111
to
+126
| fn serialize_i128(self, v: i128) -> Result<Self::Ok> { | ||
| if v > i64::MAX.into() { | ||
| Err(ConfigError::Message(format!( | ||
| "value {} is greater than the max {}", | ||
| v, | ||
| i64::MAX | ||
| ))) | ||
| } else if v < i64::MIN.into() { | ||
| Err(ConfigError::Message(format!( | ||
| "value {} is less than the min {}", | ||
| v, | ||
| i64::MIN | ||
| ))) | ||
| } else { | ||
| self.serialize_i64(v as i64) | ||
| } |
Contributor
There was a problem hiding this comment.
Why are we checking the ranges rather than serializing as a primitive?
Contributor
Author
There was a problem hiding this comment.
@epage I don't know. I did repeat the logic that was already there for the serialize_u64(). It seems strange to me too, but I can only speculate that it's there for compatibility with JSON integer types, or something.
Personally, I don't see any value in it. But changing this would be a subtle breaking change, so seemed to be out of scope for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #178
Related to #161
Synopsis
At the moment trying to deserialize
Configinto a struct withu128/i128errors:This happens even if the parsed value is small and fits into other integers.
Solution
This PR wires the
Value'si128/u128functionality intoDeserializer/Serializerimplementations.