Fix hover source display on multi-line search results#240
Open
eira-fransham wants to merge 1 commit intorust-dev-tools:masterfrom
Open
Fix hover source display on multi-line search results#240eira-fransham wants to merge 1 commit intorust-dev-tools:masterfrom
eira-fransham wants to merge 1 commit intorust-dev-tools:masterfrom
Conversation
nrc
reviewed
Jun 30, 2018
Contributor
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
This looks good, thanks! Could you rebase please?
eira-fransham
force-pushed
the
fix-search-hover
branch
from
5603799 to
c9b4ee4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this is broken because each set of lines in the search results shares one "is-source-display-open" flag. This PR changes this so that only one line per file can have its source display visible at once.