Add Alignment::new constructor function#25
Open
tomkris wants to merge 1 commit intorust-embedded-community:masterfrom
Open
Add Alignment::new constructor function#25tomkris wants to merge 1 commit intorust-embedded-community:masterfrom
tomkris wants to merge 1 commit intorust-embedded-community:masterfrom
Conversation
Currently the only way to construct Aligned value is using `aligned::Aligned` function which returns instance of `Aligned` struct. This does not work well with type aliases. For example, consider this type alias: ``` /// Aligns value at cache line boundary (assuming 64 byte cache line size) type CacheLineAligned<T> = Aligned<A64, T>; ``` User still has to use `aligned::Aligned` function to create value which breaks abstraction provided by type alias: ``` let cache_aligned_value: CacheLineAligned<u32> = aligned::Aligned(42); ``` In this commit I am implementing a conventional `new` constructor for `struct Aligned` which works with type aliases: ``` let cache_aligned_value = CacheLineAligned::new(42_u32); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only way to construct Aligned value is using
aligned::Alignedfunction which returns instance ofAlignedstruct. This does not work well with type aliases. For example, consider this type alias:User still has to use
aligned::Alignedfunction to create value which breaks abstraction provided by type alias:In this commit I am implementing a conventional
newconstructor forstruct Alignedwhich works with type aliases: