Add Raspberry Pi example#160
Closed
btielen wants to merge 6 commits into
Closed
Conversation
Author
Collaborator
|
Thanks for the PR! I haven't had much capacity to focus on this crate recently, but this PR gave me a kick to take a look at #133 again as well. IMO, I think the approach in #133 is better as it doesn't require an MSRV bump or Cargo hacks to make work so I'd like to go in that direction if you don't mind. This crate gets quite a lot of downloads so I think it's important to remain compatible even with older Rust versions. |
Author
|
No worries, your considerations make sense :) |
Collaborator
|
Thanks :). I'll close this PR in favour of #133. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepCurrent CI configuration is not passing, changed to configuration in the PR. That one succesful.
PR description
Added a simple example based on a existing example for the Raspberry Pi. Due to some strange dependencies problems, I had to switch to rust version 2021 (stabilized in rust 1.56) which automatically solved the problems. Reconfigured and improved CircleCI configuration to support multiple examples for different targets. See #48
Thanks to @PatrickLang for creating the first example.