Remove the ctype module and use core::ffi.#39
Merged
Merged
Conversation
The CStringIter was unsound, and the other type aliases didn't aid readability of the code. This also means that our CChar type now matches core::ffi::c_char, which might be a switch from signed char to unsigned char (or vice versa) on some platforms. The use of c"" literals raises the MSRV to 1.77.
Panicking in a signal handler is a non-unwindable panic that cannot be caught. So replace the handlers for any tests we do.
diondokter
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CStringIter was unsound, and the other type aliases didn't aid readability of the code.
This also means that our CChar type now matches core::ffi::c_char, which might be a switch from signed char to unsigned char (or vice versa) on some platforms.
The use of c"" literals raises the MSRV to 1.77.
Fixes #36