Open
Conversation
2fda3af to
0af1cfc
Compare
Also relies on all the targets having thumb-interworking enabled.
Thanks, macOS :/
You can't depend on the flags because they vary depending on what the machine code does.
They were created before I rebased on main, which had changes to the example programs.
I went with: * .section * .arm or .thumb * .global * .type * label * code This fixes the smp_test built for thumb mode, which was missing a .arm directive (and the start-up code doesn't work in thumb mode).
Targets added in rust-lang/rust#150138. Tested with local build of rustc. Will fail with the versions of nightly rust specified in the CI config. Need to wait for 2025-01-26 to come out. thumbv6-none-eabi isn't tested because it requires a new compiler-builtins that isn't upstream yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets added in rust-lang/rust#150138. Tested with local build of rustc.
Nightly 2026-01-25 includes these targets. Rebased to include #99 because those targets were added to nightly first (in 2026-01-24).