Added from_vec and into_sorted_vec for BinaryHeap#576
Open
silyevsk wants to merge 3 commits into
Open
Conversation
BartMassey
approved these changes
Mar 31, 2026
BartMassey
left a comment
BartMassey
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks for this! Apologies for our very slow response.
sgued
reviewed
Mar 31, 2026
Merged
sgued
approved these changes
Apr 14, 2026
Contributor
|
I pushed a rebase and fixes for my review comments |
newAM
requested changes
Apr 25, 2026
| let dst = heap.into_sorted_vec(); | ||
| assert_eq!(dst.len(), 13); | ||
| assert_eq!(dst.capacity(), 16); | ||
| assert_eq!(&dst, &array::from_fn::<u8, 13, _>(|x| 12 - x as u8)); |
Member
There was a problem hiding this comment.
array::from_fn::<u8, 13, _>(|x| 12 - x as u8) outputs [12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0] rust playground
The docstring for into_sorted_vec says it sorts in ascending order.
Maybe fixing this should just be a doc change to say that the order is different for Min vs Max heaps?
|
|
||
| ### Added | ||
|
|
||
| - Added `from_vec` and `into_sorted_vec` implementations for `BinaryHeap`. |
Member
There was a problem hiding this comment.
There's no from_vec added in this PR, rename to From<Vec>>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented: