Introduce LLVMFuzzerInitialize support#128
Merged
fitzgen merged 12 commits intorust-fuzz:mainfrom Jan 24, 2025
Merged
Conversation
- Added `example_init` to demonstrate the use of initialization code with the `fuzz_target!` macro. - Updated `fuzz_target!` macro to support an `init` parameter for executing initialization code before fuzzing. - Updated CI script to build and run the new example.
hanna-kruppe
left a comment
hanna-kruppe
left a comment
There was a problem hiding this comment.
Thanks for doing this before I got around to it! Some questions/suggestions I had while skimming the diff. I'm not a maintainer, so this doesn't carry any weight one way or another, but I hope they're still useful.
fitzgen
reviewed
Jan 22, 2025
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Nice! Looks good to me with nitpick below addressed.
Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
fitzgen
reviewed
Jan 22, 2025
This reverts commit 8188902.
fitzgen
reviewed
Jan 23, 2025
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Thanks! Looks good modulo one final suggestion for the doc comment example
Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
Contributor
Author
|
Rust fmt is my nemesis :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example_initto demonstrate the use of initialization code with thefuzz_target!macro.fuzz_target!macro to support aninitparameter for executing initialization code before fuzzing.Should I update any doc with init usage example?
Is the example good enough? Maybe an example using
staticwould be more meaningful.Close after merge:
fuzz_target!code #110