Add PeekMap and adaptors::peek_map#809
Closed
MiguelX413 wants to merge 1 commit intorust-itertools:masterfrom
Closed
Add PeekMap and adaptors::peek_map#809MiguelX413 wants to merge 1 commit intorust-itertools:masterfrom
MiguelX413 wants to merge 1 commit intorust-itertools:masterfrom
Conversation
Member
|
Sidenote: CI only failed because of missing documentation (and missing new tests). Hi. I'm still writing the CONTRIBUTING.md file in #767 but you might find its draft interesting. I'm first wondering if it is useful enough to be integrated? Do you have an usecase example? Maybe it should be proposed to libcore first? And what would be the alternative with the current iterator+itertools? For now, all I see is use "batching" (which is definitely not obvious and the size hint info would be lost). (It makes me think of MapWindows<N=2> but different, and a bit of #771.) EDIT: I think it could be |
Author
|
I'll close this while rust-lang/rust#118474 is in progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request to this project so I would appreciate feedback. I will add documentation soon.