Add the str type#441
Merged
jackh726 merged 5 commits intorust-lang:masterfrom May 10, 2020
AzureMarker:feature/str-typename
Merged
Add the str type#441jackh726 merged 5 commits intorust-lang:masterfrom AzureMarker:feature/str-typename
jackh726 merged 5 commits intorust-lang:masterfrom
AzureMarker:feature/str-typename
Conversation
AzureMarker
commented
May 6, 2020
Member
|
I skimmed the PR, but not enough for a "review" yet. But I did want to bring up rust-lang/rust#70911. Which might mean that we don't need to special type |
Contributor
Author
|
(BTW, I assume you want PRs to fix conflicts with master by rebasing instead of merging, like in rust-lang/rust, but let me know if this isn't the case) |
Member
Yes please :) You'll have to rebase again unfortunately |
Contributor
Author
|
The rebase is no problem 🙂 |
jackh726
requested changes
May 9, 2020
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
Can you add tests for not Copy/Clone?
jackh726
approved these changes
May 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #437