Update comment about buggy static file serving#1863
Merged
syphar merged 2 commits intorust-lang:masterfrom Sep 30, 2022
Merged
Conversation
github-actions
bot
added
the
S-waiting-on-review
jsha
force-pushed
the
update-static-file-comment
branch
from
3895522 to
ebbb4bd
Compare
jsha
force-pushed
the
update-static-file-comment
branch
from
ebbb4bd to
acbd416
Compare
Nemo157
approved these changes
Sep 29, 2022
Contributor
Nemo157
left a comment
Nemo157
left a comment
There was a problem hiding this comment.
Looks correct to my understanding.
jyn514
approved these changes
Sep 29, 2022
Co-authored-by: Joshua Nelson <github@jyn.dev>
syphar
approved these changes
Sep 30, 2022
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust-lang/rust#101702 (comment) @Nemo157 pointed out that static file handling is hacky, and even pointed out to me the relevant lines of code. But after reading the comment and the issues I still didn't understand exactly what was happening, what the desired direction was, and whether there were multiple intersecting bugs.
After staring at the code for a little while I wrote up a summary to see if I properly understand, and hopefully make it clearer for the next person who comes along. Please correct what I have gotten wrong. :-)