Open
Conversation
Without a definition, cargo defaults to the 2015 edition, which is the definition the codebase is compatible with. Specifying this explicitly aids in the migration to later editions, by allowing the use of cargo fix.
No changes needed to the codebase compared to the 2018 edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the codebase does not specify an edition, which results in a warning and cargo uses the 2015 edition. This PR takes the codebase to the 2021 edition in steps. The first commit specifies the current 2015 edition. The second commit specifies the 2018 edition, and updates the codebase to use the 2018 path conventions described at https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html. The third commit bumps to the 2021 edition. No code changes were required to support the 2021 edition.