Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,40 @@ Language changes in Rust 1.91.0

- `Lower pattern bindings in the order they're written and base drop order on primary bindings' order <https://github.com/rust-lang/rust/pull/143764>`_

- Changed paragraphs:

- :p:`fls_g07zq3n55094`
- :p:`fls_8luyomzppck`
- :p:`fls_kv533rntni1x`
- :p:`fls_62626ws222op`
- :p:`fls_q0z46h1gnzez`
- :p:`fls_1r0vm6rg13o9`
- :p:`fls_am5h8r887bz5`
- :p:`fls_eppmiloh7bgg`
- :p:`fls_gwc08xayno7q`
- :p:`fls_19iygu12s315`
- :p:`fls_r307spfk6cs9`
- :p:`fls_qhdofvbso3gl`
- :p:`fls_drb114dtvlpt`
- :p:`fls_uxysntb3u03j`
- :p:`fls_vstdqifqipbh`

Copy link
Contributor

@PLeVasseur PLeVasseur Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Changed paragraphs" list, two IDs from PR 631's diff look missing. One is a list-structure shift (fls_wh201rmh6u6d), the other switches :dt: to :t: (fls_y3oputy9e0sz).

Suggested change
- :p:`fls_wh201rmh6u6d`
- :p:`fls_y3oputy9e0sz`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipped those because I see them not as semantic changes

- New paragraphs:

- :p:`fls_W2S2FrkuedYC`
- :p:`fls_dhfIPP4yR3Tt`
- :p:`fls_zxFM7EoE2Xq8`
- :p:`fls_093YxG6YXQz2`
- :p:`fls_gNWXh61ZXXt8`
- :p:`fls_VQMmveZUfNTn`
- :p:`fls_72JHo343O7jp`
- :p:`fls_6bwTtGKb7ba7`
- :p:`fls_YDVgFaTQwcL8`
- :p:`fls_zv73CR8rplIa`
- :p:`fls_tZJgZDWVChJV`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "New paragraphs" list for this item, I think we're missing a few IDs from PR #631's spec changes:

Suggested change
- :p:`fls_LnPDQW3bnNUw`
- :p:`fls_sw6HrsxsnG2y`
- :p:`fls_urIJ5JNHLhm6`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipped those since they are glossary entries, but am not sure I should have... what say @kirtchev-adacore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how I done it in the past is I would define the term inline, not in glossary, and it's then that I would add it to changelog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should treat new paragraphs in the glossary as "regular" new paragraphs, and document them in the changelog.

Copy link
Member Author

@tshepang tshepang Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as agreed in the FLS meet, I replicated the glossary entry inline so that we can put it in the changelog, since the glossary is informational

also

  • fls_sw6HrsxsnG2y already has an entry inline
  • fls_urIJ5JNHLhm6 is a glossary-only reference, pointing to the section where the glossary entry is introduced inline

f667314

- Removed paragraph: :p:`fls_67ajub7d2b4c`

- `Stabilize declaration of C-style variadic functions for 'sysv64', 'win64', 'efiapi', and 'aapcs' ABIs <https://github.com/rust-lang/rust/pull/144066>`_.
This brings these ABIs in line with the C ABI: variadic functions can be declared in extern blocks but not defined.

Expand Down
3 changes: 1 addition & 2 deletions src/ownership-and-deconstruction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ When a :t:`drop scope` is left, all :t:`[value]s` associated with that
:t:`Temporaries <temporary>` are :t:`dropped` in reverse creation order.

* :dp:`fls_g07zq3n55094`
All other :t:`bindings` are :t:`dropped` in reverse declaration order.
All other :t:`[binding]s` are :t:`dropped` in reverse declaration order.

:dp:`fls_zQGkVGWIzMQ7`
When a :t:`drop scope` of a :t:`function` is left, then each
Expand Down Expand Up @@ -773,4 +773,3 @@ Dropping proceeds as follows:
drop_order(Ok([PrintOnDrop("1"), PrintOnDrop("2")]));

drop_order(Err([PrintOnDrop("2"), PrintOnDrop("1")]));

3 changes: 3 additions & 0 deletions src/patterns.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ with :t:`keyword` ``mut`` containing an :t:`identifier pattern`.
An or-pattern shall not appear in the :t:`pattern-without-alternation` of a
:t:`closure parameter`, a :t:`function parameter`, or a :t:`let binding`.

:dp:`fls_6bwTtGKb7ba7`
A :dt:`let binding` is the :t:`binding` introduced by a :t:`let statement`, an :t:`if let expression`, or a :t:`while let loop expression`.

:dp:`fls_8luyomzppck`
Any two :t:`[subpattern]s` of an :t:`or-pattern` are subject to the following
restrictions:
Expand Down