-
Notifications
You must be signed in to change notification settings - Fork 40
add missing changelog entries for #631 #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -100,6 +100,40 @@ Language changes in Rust 1.91.0 | |||||||||||
|
|
||||||||||||
| - `Lower pattern bindings in the order they're written and base drop order on primary bindings' order <https://github.com/rust-lang/rust/pull/143764>`_ | ||||||||||||
|
|
||||||||||||
| - Changed paragraphs: | ||||||||||||
|
|
||||||||||||
| - :p:`fls_g07zq3n55094` | ||||||||||||
| - :p:`fls_8luyomzppck` | ||||||||||||
| - :p:`fls_kv533rntni1x` | ||||||||||||
| - :p:`fls_62626ws222op` | ||||||||||||
| - :p:`fls_q0z46h1gnzez` | ||||||||||||
| - :p:`fls_1r0vm6rg13o9` | ||||||||||||
| - :p:`fls_am5h8r887bz5` | ||||||||||||
| - :p:`fls_eppmiloh7bgg` | ||||||||||||
| - :p:`fls_gwc08xayno7q` | ||||||||||||
| - :p:`fls_19iygu12s315` | ||||||||||||
| - :p:`fls_r307spfk6cs9` | ||||||||||||
| - :p:`fls_qhdofvbso3gl` | ||||||||||||
| - :p:`fls_drb114dtvlpt` | ||||||||||||
| - :p:`fls_uxysntb3u03j` | ||||||||||||
| - :p:`fls_vstdqifqipbh` | ||||||||||||
|
|
||||||||||||
| - New paragraphs: | ||||||||||||
|
|
||||||||||||
| - :p:`fls_W2S2FrkuedYC` | ||||||||||||
| - :p:`fls_dhfIPP4yR3Tt` | ||||||||||||
| - :p:`fls_zxFM7EoE2Xq8` | ||||||||||||
| - :p:`fls_093YxG6YXQz2` | ||||||||||||
| - :p:`fls_gNWXh61ZXXt8` | ||||||||||||
| - :p:`fls_VQMmveZUfNTn` | ||||||||||||
| - :p:`fls_72JHo343O7jp` | ||||||||||||
| - :p:`fls_6bwTtGKb7ba7` | ||||||||||||
| - :p:`fls_YDVgFaTQwcL8` | ||||||||||||
| - :p:`fls_zv73CR8rplIa` | ||||||||||||
| - :p:`fls_tZJgZDWVChJV` | ||||||||||||
|
|
||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the "New paragraphs" list for this item, I think we're missing a few IDs from PR #631's spec changes:
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. skipped those since they are glossary entries, but am not sure I should have... what say @kirtchev-adacore
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how I done it in the past is I would define the term inline, not in glossary, and it's then that I would add it to changelog
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should treat new paragraphs in the glossary as "regular" new paragraphs, and document them in the changelog.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as agreed in the FLS meet, I replicated the glossary entry inline so that we can put it in the changelog, since the glossary is informational also
|
||||||||||||
| - Removed paragraph: :p:`fls_67ajub7d2b4c` | ||||||||||||
|
|
||||||||||||
| - `Stabilize declaration of C-style variadic functions for 'sysv64', 'win64', 'efiapi', and 'aapcs' ABIs <https://github.com/rust-lang/rust/pull/144066>`_. | ||||||||||||
| This brings these ABIs in line with the C ABI: variadic functions can be declared in extern blocks but not defined. | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the "Changed paragraphs" list, two IDs from PR 631's diff look missing. One is a list-structure shift (
fls_wh201rmh6u6d), the other switches:dt:to:t:(fls_y3oputy9e0sz).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipped those because I see them not as semantic changes