Check option names conflict on debug build#116
Open
rhysd wants to merge 1 commit intorust-lang:masterfrom
Open
Check option names conflict on debug build#116rhysd wants to merge 1 commit intorust-lang:masterfrom
rhysd wants to merge 1 commit intorust-lang:masterfrom
Conversation
254430e to
343542c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently getopts doesn't complain that multiple options have the same short/long option names. However these cases are always mistakes because when one option uses some option name, other options which use the same name cannot be specified at all.
This mistake tends to happen when the number of options/flags grows bigger.
This PR checks the conflict on debug build and notifies the mistake to the user.