Remove trailing semicolon from internal err! macro#631
Merged
ehuss merged 1 commit intorust-lang:masterfrom Jan 3, 2021
Merged
Remove trailing semicolon from internal err! macro#631ehuss merged 1 commit intorust-lang:masterfrom
err! macro#631ehuss merged 1 commit intorust-lang:masterfrom
Conversation
This will allow this crate to continue to compile if rust-lang/rust#33953 is fixed
Contributor
Author
|
Blocked on rust-lang/rustfmt#4507 |
Contributor
Author
|
This PR's code is now accepted by the latest nightly rustfmt: It looks like CI is gating on rustfmt for stable 1.47.0. Do I need to wait for a stable release containing the rustfmt fix before this PR can be merged? |
ehuss
approved these changes
Jan 3, 2021
Contributor
ehuss
left a comment
ehuss
left a comment
There was a problem hiding this comment.
1.49 is now stable, so I think it is safe to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow this crate to continue to compile if
rust-lang/rust#33953 is fixed