Conversation
|
I also have not modified the documentation, so there's probably some stuff that needs to change. |
|
Could you please describe the high level solution to the problem that you implemented? |
|
Alright, no problem. I tried to keep the logic used in the original code the same, so most all of the changes were around getting the same code to work without relying on Because the only characters we need to match against are the few special characters (like By doing so, we just check need to check whatever value is retrieved from the iterator against the special characters retrieved from the platform-dependent trait/struct. If the value is not a special character, we can just store it in |
|
Any feedback? |
Merge from master
|
Seems force-pushing broke the diff, the branch now only has eeb8a73. |
This should resolve #23. The implementation works on both Linux and Windows for me (with the available tests). It's still very possible something broke though, so I'd appreciate it if another set of eyes could carefully check. I'm also very open to design changes if desired.
As part of the changes, I removed the methods
matches_path()andmatches_path_with()as they are now redundant, but I can add them back for the sake of backwards-compatibility.