Upgrade CI (clippy, more targets)#52
Conversation
| local-dir: target/doc | ||
| keep-history: false | ||
| on: | ||
| branch: master |
There was a problem hiding this comment.
I don't know if you are interested into deploying the docs with the nightly features to github-pages. If not I can just remove the deploy key. Otherwise, you'd need to generate a token and push it to travis as GITHUB_TOKEN.
There was a problem hiding this comment.
I think the only difference is that HashMap::new is const fn on nightly. Not worth a completely separate set of docs IMO.
There was a problem hiding this comment.
I thought the serde and rayon features would add more stuff. I'll remove the deploy key then.
There was a problem hiding this comment.
Oh! I forgot about those! Yes, please do keep the docs in that case.
| Group(ptr::read(ptr as *const _)) | ||
| #[allow(clippy::cast_ptr_alignment)] | ||
| pub unsafe fn load_aligned(ptr: *const u8) -> Self { | ||
| // FIXME: use align_offset once it stabilizes |
There was a problem hiding this comment.
What do we need align_offset for? The current code seems to work fine in miri.
There was a problem hiding this comment.
Align offset is the std lib function I always use for this, but it's unstable.
|
ping @gnzlbg |
|
Failure on 1.29, but in #46 I'm bumping the minimum version to 1.31 anyways. |
|
On 1.31: |
|
@Amanieu it appears that clippy suggests using |
|
bors r+ |
Build succeeded
|
2 participants
No description provided.