make automated pull PR title more clear#33
Conversation
This more clearly indicates that we are pulling from a given repository
|
Is the rustc commit ID available at this time? It would be nice if the body also said |
|
Actually, could it just pick the merge commit message and use that for the title+body? It should be the last commit at this point, so I think That would mention rust-lang/rust, the specific commit, as well as link the diff and link back to josh-sync (e.g. rust-lang/compiler-builtins@66ffdef). The downside is that for repos that use merge commits, you get the same message repeated twice in history. |
|
@tgross35 nice suggestion there... I added your title suggestion to the body instead |
|
This would require some changes in subtree repos, which I'm not sure is worth it (https://github.com/rust-lang/rust/blob/0d162b25edd5bf0dba9a22e83b614f1113e90474/src/tools/rust-analyzer/triagebot.toml#L20, https://github.com/rust-lang/rust/blob/71963027884c9d995173aca298b0fe614e145bde/library/compiler-builtins/triagebot.toml#L7). Changing the PR message would be nice though. I think we could just use |
This more clearly indicates that we are pulling from a given repository