Prepare for being included via crates.io into std#1134
Conversation
|
@alexcrichton: no appropriate reviewer found, use r? to override |
|
r? @gnzlbg |
|
LGTM. |
| default = ["use_std"] | ||
| use_std = [] | ||
| align = [] | ||
| rustc-dep-of-std = ['align', 'rustc-std-workspace-core'] |
There was a problem hiding this comment.
I don't know if this should enable use_std as well to be sure - it should be enabled by default anyways as long as libstd doesn't use default-features=false.
There was a problem hiding this comment.
Nah this specifically actually doesn't want use_std because std isn't built yet! (this'll be a dependency of std)
|
The style checks are failing |
eac2013 to
aa5304f
Compare
|
@bors: r=gnzlbg |
|
📌 Commit aa5304f has been approved by |
aa5304f to
05ff162
Compare
|
@bors: r=gnzlbg |
|
📌 Commit 05ff162 has been approved by |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
|
☔ The latest upstream changes (presumably #1129) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit prepares the `libc` crate to be included directly into the standard library via crates.io. More details about this can be found on rust-lang/rust#56092, but the main idea is that this crate now depends on core/compiler-builtins explicitly (but off-by-default). The main caveat here is that this activates `no_core` when building as part of libstd, which means that it needs to explicitly have an `iter` and `option` module for the expansion of `for` loops to work.
05ff162 to
91bd079
Compare
|
@bors: r=gnzlbg |
|
📌 Commit 91bd079 has been approved by |
Prepare for being included via crates.io into std This commit prepares the `libc` crate to be included directly into the standard library via crates.io. More details about this can be found on rust-lang/rust#56092, but the main idea is that this crate now depends on core/compiler-builtins explicitly (but off-by-default). The main caveat here is that this activates `no_core` when building as part of libstd, which means that it needs to explicitly have an `iter` and `option` module for the expansion of `for` loops to work.
|
☀️ Test successful - status-appveyor, status-travis |
This commit prepares the
libccrate to be included directly into thestandard library via crates.io. More details about this can be found on
rust-lang/rust#56092, but the main idea is that this crate now depends
on core/compiler-builtins explicitly (but off-by-default).
The main caveat here is that this activates
no_corewhen building aspart of libstd, which means that it needs to explicitly have an
iterand
optionmodule for the expansion offorloops to work.