Add musl support for MIPS64 & bump to 0.2.63 by xen0n · Pull Request #1449 · rust-lang/libc

xen0n · 2019-07-31T06:01:25Z

Tested with patched stage2; both static and dynamic binaries confirmed working.

Initial CI support in the form of no-core targets are added.

rust-highfive · 2019-07-31T06:01:29Z

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

xen0n · 2019-07-31T12:20:03Z

failure is the same as #1450

xen0n · 2019-08-02T09:49:39Z

The i686 mingw failure seems unrelated.

bors · 2019-08-08T19:40:12Z

☔ The latest upstream changes (presumably #1376) made this pull request unmergeable. Please resolve the merge conflicts.

ci/azure.yml

gnzlbg

So this all looks good to me.

If there is librustc_target support upstream for these, I would prefer if you would add these targets to ci/build.sh (to the LINUX_NIGHTLY_NOCORE env variable), so that we at least test that these build properly.

Once you get libstd support up and running in rust-lang/rust, then it might be worth it to consider adding the run-time tests for these, but that should happen in a future PR, and not here.

xen0n · 2019-08-09T11:28:57Z

For the record, I for some unknown reason included CI changes in both of the PRs, so neither would build... 🤦‍♂

gnzlbg · 2019-08-09T11:39:02Z

You can remove the changes to azure.yml here. If you don't want to wait for the target to be available, you can add a .json file here if you want, but since there is a PR upstream already, I'll just wait on this till that lands.

…ichton Add builtin targets for mips64(el)-unknown-linux-musl This is prerequisite for rust-lang/libc#1449. Tested locally to produce working static and dynamic binaries, ~~but CI config is untested for now~~ CI is to be added in a follow-up PR. *edit: dynamic binaries also confirmed working!*

gnzlbg · 2019-08-12T08:38:58Z

This needs to be updated (e.g. remove the comments in the azure.yml file, or enable those jobs), also, these targets need to be added to the ci/build.sh file (probably to the NIGHTLY_NOCORE list until we start shipping core and/or libstd for these targets).

…ichton Add builtin targets for mips64(el)-unknown-linux-muslabi64 This is prerequisite for rust-lang/libc#1449. Tested locally to produce working static and dynamic binaries, ~~but CI config is untested for now~~ CI is to be added in a follow-up PR. *edit: dynamic binaries also confirmed working!* *edit 2: changed triples to include ABI, and removed stray `crt_static_default = false` declarations to be consistent with other musl targets`

xen0n · 2019-08-12T17:14:52Z

Updated. The librustc_target enablement should land today; this should go in afterwards. (And with a version bump.)

gnzlbg · 2019-08-14T08:33:13Z

@bors: r+

bors · 2019-08-14T08:33:15Z

📌 Commit da1aca0 has been approved by gnzlbg

bors · 2019-08-14T08:33:25Z

⌛ Testing commit da1aca0 with merge 832549a...

Add musl support for MIPS64 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.

xen0n · 2019-08-14T09:15:47Z

Ah. The rustc change didn't make it in, in fact it's still waiting.

Once rust-lang/rust#63165 lands this can be retried; merging of this should be avoided before that.

bors · 2019-08-14T11:03:25Z

💥 Test timed out

…ichton Add builtin targets for mips64(el)-unknown-linux-muslabi64 This is prerequisite for rust-lang/libc#1449. Tested locally to produce working static and dynamic binaries, ~~but CI config is untested for now~~ CI is to be added in a follow-up PR. *edit: dynamic binaries also confirmed working!* *edit 2: changed triples to include ABI, and removed stray `crt_static_default = false` declarations to be consistent with other musl targets*

gnzlbg · 2019-08-15T18:06:51Z

@xen0n while the PR to rust-lang/rust landed, new nightly toolchains are only created approx. once per day, so usually you have to wait until tomorrow. Don't despair ;)

gnzlbg · 2019-08-16T16:34:45Z

@bors: r+

bors · 2019-08-16T16:34:46Z

📌 Commit 42139b8 has been approved by gnzlbg

bors · 2019-08-16T19:33:59Z

⌛ Testing commit 42139b8 with merge dd8f908...

Add musl support for MIPS64 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.

bors · 2019-08-16T21:09:06Z

💔 Test failed - status-azure

… ones

xen0n · 2019-08-17T02:29:30Z

Turns out I misunderstood the new CI pipeline...

libc/ci/azure-install-rust.yml

Lines 24 to 30 in 4bd0c00

    
             - script: | 
        
                 set -ex 
        
                 if [ -n "${TARGET}" ]; then 
        
                   rustup target add $TARGET 
        
                 fi 
        
               condition: ne( variables['Agent.OS'], 'Windows_NT' ) 
        
               displayName: Install target (unix)

It seems any target in the build matrix needs to have std already built. Hence I'm taking the new targets out of the build matrix just like other NO_CORE targets.

gnzlbg · 2019-08-17T09:16:25Z

It seems any target in the build matrix needs to have std already built.

Yes, you only can do that once you have enabled std support in rust-lang/rust, which needs to happen after the initial changes here (where we only check that the library builds correctly).

gnzlbg · 2019-08-17T09:17:37Z

@bors: r+

bors · 2019-08-17T09:17:39Z

📌 Commit 435cdee has been approved by gnzlbg

bors · 2019-08-17T10:42:06Z

⌛ Testing commit 435cdee with merge 7decbdd...

Add musl support for MIPS64 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.

xen0n · 2019-08-17T11:17:48Z

We're blocked by #1473. Should we just cherry-pick the build-fixing commit to at least unblock things?

bors · 2019-08-17T11:28:53Z

💔 Test failed - status-azure

gnzlbg · 2019-08-17T14:16:13Z

@bors: retry

Add musl support for MIPS64 & bump to 0.2.63 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.

bors · 2019-08-17T16:39:22Z

⌛ Testing commit 435cdee with merge 4b610e6...

bors · 2019-08-17T18:02:52Z

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 4b610e6 to master...

xen0n · 2019-08-19T05:12:46Z

Could this version bump be pushed to crates.io, so I can continue work on upstreaming the corresponding std support?

gnzlbg · 2019-08-19T13:37:45Z

Sure

gnzlbg · 2019-08-20T11:14:54Z

Released, sorry for the delay, we had too many time outs the last couple of days.

rust-highfive assigned gnzlbg Jul 31, 2019

xen0n mentioned this pull request Jul 31, 2019

Add builtin targets for mips64(el)-unknown-linux-muslabi64 rust-lang/rust#63165

Merged

xen0n force-pushed the mips64-musl-targets branch 4 times, most recently from d7b3a2e to c6a8efd Compare August 2, 2019 07:59

xen0n changed the title ~~[WIP] add musl support for MIPS64~~ Add musl support for MIPS64 Aug 2, 2019

xen0n marked this pull request as ready for review August 2, 2019 09:27

xen0n force-pushed the mips64-musl-targets branch from c6a8efd to 240b370 Compare August 9, 2019 02:05

gnzlbg reviewed Aug 9, 2019

View reviewed changes

ci/azure.yml Outdated Show resolved Hide resolved

gnzlbg suggested changes Aug 9, 2019

View reviewed changes

xen0n force-pushed the mips64-musl-targets branch from 240b370 to da1aca0 Compare August 12, 2019 14:48

xen0n added 4 commits August 17, 2019 10:25

Reorganize constant declarations to make up space for MIPS64-specific…

9df2deb

… ones

Add mips64 musl support

cd51d11

ci: Add mips64(el)-unknown-linux-muslabi64 as initially no_core targets

2883e4c

Bump version to 0.2.63

435cdee

xen0n force-pushed the mips64-musl-targets branch from 42139b8 to 435cdee Compare August 17, 2019 02:26

xen0n mentioned this pull request Aug 17, 2019

Update minor patch version to 0.2.63 #1479

Closed

xen0n changed the title ~~Add musl support for MIPS64~~ Add musl support for MIPS64 & bump to 0.2.63 Aug 17, 2019

bors merged commit 435cdee into rust-lang:master Aug 17, 2019

xen0n deleted the mips64-musl-targets branch August 19, 2019 05:11

Conversation

xen0n commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jul 31, 2019

Uh oh!

xen0n commented Jul 31, 2019

Uh oh!

xen0n commented Aug 2, 2019

Uh oh!

bors commented Aug 8, 2019

Uh oh!

Uh oh!

gnzlbg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xen0n commented Aug 9, 2019

Uh oh!

gnzlbg commented Aug 9, 2019

Uh oh!

gnzlbg commented Aug 12, 2019

Uh oh!

xen0n commented Aug 12, 2019

Uh oh!

gnzlbg commented Aug 14, 2019

Uh oh!

bors commented Aug 14, 2019

Uh oh!

bors commented Aug 14, 2019

Uh oh!

xen0n commented Aug 14, 2019

Uh oh!

bors commented Aug 14, 2019

Uh oh!

gnzlbg commented Aug 15, 2019

Uh oh!

gnzlbg commented Aug 16, 2019

Uh oh!

bors commented Aug 16, 2019

Uh oh!

bors commented Aug 16, 2019

Uh oh!

bors commented Aug 16, 2019

Uh oh!

xen0n commented Aug 17, 2019

Uh oh!

gnzlbg commented Aug 17, 2019

Uh oh!

gnzlbg commented Aug 17, 2019

Uh oh!

bors commented Aug 17, 2019

Uh oh!

bors commented Aug 17, 2019

Uh oh!

xen0n commented Aug 17, 2019

Uh oh!

bors commented Aug 17, 2019

Uh oh!

gnzlbg commented Aug 17, 2019

Uh oh!

bors commented Aug 17, 2019

Uh oh!

bors commented Aug 17, 2019

Uh oh!

xen0n commented Aug 19, 2019

Uh oh!

gnzlbg commented Aug 19, 2019

Uh oh!

gnzlbg commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xen0n commented Jul 31, 2019 •

edited

Loading

gnzlbg left a comment •

edited

Loading