Skip to content

linux musl bring ucontext api for related archs#2430

Closed
devnexen wants to merge 1 commit intorust-lang:masterfrom
devnexen:musl_ucontextapi
Closed

linux musl bring ucontext api for related archs#2430
devnexen wants to merge 1 commit intorust-lang:masterfrom
devnexen:musl_ucontextapi

Conversation

@devnexen
Copy link
Contributor

@devnexen devnexen commented Oct 3, 2021

No description provided.

@rust-highfive
Copy link

rust-highfive commented Oct 3, 2021

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Oct 6, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2021

📌 Commit e7601c6 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 6, 2021

⌛ Testing commit e7601c6 with merge fbd963d...

bors added a commit that referenced this pull request Oct 6, 2021
@bors
Auto merge of #2430 - devnexen:musl_ucontextapi, r=Amanieu
fbd963d 
linux musl bring ucontext api for related archs
@bors
Copy link
Contributor

bors commented Oct 6, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Oct 6, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2021

📌 Commit 711d64d has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 6, 2021

⌛ Testing commit 711d64d with merge d7fea32...

bors added a commit that referenced this pull request Oct 6, 2021
@bors
Auto merge of #2430 - devnexen:musl_ucontextapi, r=Amanieu
d7fea32 
linux musl bring ucontext api for related archs
@bors
Copy link
Contributor

bors commented Oct 6, 2021

💔 Test failed - checks-actions

@devnexen
Copy link
Contributor Author

devnexen commented Oct 6, 2021

I do not know how to get passed this macOs backward incompatibility.

@Amanieu
Copy link
Member

Amanieu commented Oct 6, 2021

The semver checks don't actually block CI. The actual error is lower down: https://github.com/rust-lang/libc/runs/3814302629

@Amanieu
Copy link
Member

Amanieu commented Oct 10, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 10, 2021

📌 Commit 460dd58 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 10, 2021

⌛ Testing commit 460dd58 with merge 251dcf5...

bors added a commit that referenced this pull request Oct 10, 2021
@bors
Auto merge of #2430 - devnexen:musl_ucontextapi, r=Amanieu
251dcf5 
linux musl bring ucontext api for related archs
@bors
Copy link
Contributor

bors commented Oct 10, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

JohnTitor commented Oct 13, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 13, 2021

📌 Commit 8aa4c8c has been approved by JohnTitor

bors added a commit that referenced this pull request Oct 13, 2021
@bors
Auto merge of #2430 - devnexen:musl_ucontextapi, r=JohnTitor
a460e7f 
linux musl bring ucontext api for related archs
@bors
Copy link
Contributor

bors commented Oct 13, 2021

⌛ Testing commit 8aa4c8c with merge a460e7f...

@bors
Copy link
Contributor

bors commented Oct 13, 2021

💔 Test failed - checks-actions

@bors
Copy link
Contributor

bors commented Jan 18, 2022

☔ The latest upstream changes (presumably #2615) made this pull request unmergeable. Please resolve the merge conflicts.

@kaniini
Copy link
Contributor

kaniini commented Jan 19, 2022

This pull request is wrong. The getcontext et al API are not provided by musl directly, but by my libucontext library: https://gitea.treehouse.systems/ariadne/libucontext

@devnexen devnexen closed this Jan 19, 2022
@Jake-Shadle Jake-Shadle mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@Amanieu Amanieu

Labels

S-waiting-on-author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devnexen @rust-highfive @Amanieu @bors @JohnTitor @kaniini