freebsd: Correctly detect FreeBSD version#2603
Closed
amshafer wants to merge 1 commit intorust-lang:masterfrom
Closed
freebsd: Correctly detect FreeBSD version#2603amshafer wants to merge 1 commit intorust-lang:masterfrom
amshafer wants to merge 1 commit intorust-lang:masterfrom
Conversation
This change removes the CI check that applies to freebsd version cfg. This is causing problems where the freebsd version defaults to 11 when CI is not enabled, some types may be incorrect on a > 11 system, and compilation failures ensue. A concrete example is libc::dev_t. This was defaulting to u32 on my FreeBSD 13-STABLE desktop, when it should have been u64. I couldn't compile anything that uses libc::devname_r as a result.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
Member
|
Note that there's a previous attempt about that, #2581, and it was reverted as it causes an unwanted regression. See the discussion on the mentioned PR. |
Contributor
This means we're missing something like #[cfg_attr(all(target_os = "freebsd", freebsd11), link_name = "devname_r@FBSD_1.0")]I really think we should add versioned symbols to ALL functions already. |
Member
|
I'm going to close this with the above reason, we should discuss how we treat these cfgs first, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the CI check that applies to freebsd version cfg. This is causing problems where the freebsd version defaults to 11 when CI is not enabled, some types may be incorrect on a > 11 system,
and compilation failures ensue.
A concrete example is libc::dev_t. This was defaulting to u32 on my FreeBSD 13-STABLE desktop, when it should have been u64. I couldn't compile anything that uses libc::devname_r as a result.