Closed
Conversation
no-one uses __ipc_perm_key as this is a musl implementation detail musl defines `__key` as an alias to this field. `key` is also defined as an alias when _GNU_SOURCE or _BSD_SOURCE is defined, however `__key` is chosen for compatibility with the glibc version.
rustbot
added
O-arm
O-linux
O-mips
O-musl
O-riscv
O-unix
O-x86
S-waiting-on-review
labels
Contributor
Author
|
Closing in favor of #4443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change renames the internal name
__ipc_perm_keyto__keyin theipc_permstruct for musl libc, to be consistent with the__seqfield as well as the glibc version of the same type. This works, because__ipc_perm_keyis defined as__key, effectively adding an alias to the field.__seqis defined in the same way, as an alias to__ipc_perm_seq, however unlike__keythis internal name was not present in the first commit__seqSources
musl: __key define/alias
musl: ipc_perm type
glibc version of ipc_perm in libc crate
code search for
__ipc_perm_key(only auto generated code and musl mirrors)Checklist
libc-test/semverhave been updated (not applicable)*LASTor*MAXareincluded (see rust-lang/libc#3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI