musl: fix test build with musl 1.2.0+#4438
Merged
tgross35 merged 1 commit intorust-lang:mainfrom May 1, 2025
Merged
Conversation
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. Fixes: 3305
rustbot
added
S-waiting-on-review
stable-nominated
tgross35
approved these changes
May 1, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Looks great, thank you!
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. Fixes: 3305 (cherry picked from commit aa08592) (backport <rust-lang#4438>)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. Fixes: 3305 (cherry picked from commit aa08592) (backport <rust-lang#4438>)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. Fixes: 3305 (backport <rust-lang#4438>) (cherry picked from commit aa08592)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. Fixes: 3305 (backport <rust-lang#4438>) (cherry picked from commit aa08592)
tgross35
added
stable-applied
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. Fixes: 3305 (backport <rust-lang#4438>) (cherry picked from commit aa08592)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since musl 1.2.0, the utmpx.ut_session type changed from long to int (with padding). For now, skip the test for this field. This fixes #3305. This change type can probably be changed and this commit reverted when #3068 is merged.
Sources
diff
permalink
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see rust-lang/libc#3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated