Add additional fields to statx#4621
Conversation
|
The CI failure is a Clippy complaints about code I didn't change: If the maintainers want I can send a pr for this, but I don't think it should be done in this pr. |
|
These haven't yet been updated in glibc https://github.com/bminor/glibc/blob/a6eb8285d9bfb7ec0875b85ca356e833ff964d4f/io/bits/types/struct_statx.h#L30 or musl, so we should wait for that. @rustbot blocked
That has been fixed, should go away with a rebase |
|
For reference, here's the glibc patchset adding this https://inbox.sourceware.org/libc-alpha/20251003194707.2326679-1-adhemerval.zanella@linaro.org/ |
|
@tgross35 it seems like the patchset was merged: https://github.com/bminor/glibc/blob/bd569425330c6f5644c232b4b253e9ab905fcdba/io/bits/types/struct_statx.h#L56-L62. Are there any requirements in terms of release/deployment of the glibc changes (i.e. a minimum version)? Or should I rebase and it's good to merge? |
tgross35
left a comment
There was a problem hiding this comment.
@tgross35 it seems like the patchset was merged: https://github.com/bminor/glibc/blob/bd569425330c6f5644c232b4b253e9ab905fcdba/io/bits/types/struct_statx.h#L56-L62. Are there any requirements in terms of release/deployment of the glibc changes (i.e. a minimum version)? Or should I rebase and it's good to merge?
Thanks for the update, nope that's about it. I'll merge after rebase and CI passing 👍
(Note you may need to skip these fields in libc-test/build.rs)
This is accurate for Linux v6.16.
Android doesn't have them (yet).
442c302 to
854ab51
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Rebased and added the padding. |
Description
Updates statx to include all fields as of Linux v6.16.
Sources
https://github.com/torvalds/linux/blob/038d61fd642278bab63ee8ef722c50d10ab01e8f/include/uapi/linux/stat.h#L99-L193
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated