Add more wasi definitions for libstd#4747
Merged
tgross35 merged 3 commits intorust-lang:mainfrom Oct 16, 2025
Merged
Conversation
This commit fills out definitions in libc for rust-lang/rust#147572 notably filling out some fs-related functions as well as many pthread-related functions. The pthread-related functions were not available originally with wasi-libc but nowadays are stubs for single-threaded behavior. The goal is to make wasi targets more "unix like" in libstd and have less WASI-specific code.
Member
Author
|
@rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
tgross35
reviewed
Oct 15, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
This looks good to me, just a question about the arrays
src/wasi/mod.rs
Outdated
Comment on lines
178
to
181
| #[repr(align(4))] | ||
| pub struct pthread_attr_t { | ||
| size: [u8; 36], | ||
| } |
Contributor
There was a problem hiding this comment.
Is 64-bit wasi something we'll need to support? If so, maybe [c_ulong; if size_of::<c_long>() == 8 { 7 } else { 9 }] to account for that, and it's a bit easier to match up to the source anyway (assuming this is the right definition https://github.com/WebAssembly/wasi-libc/blob/6b45da5b05bc0edda355a6de46101d4b21631985/libc-top-half/musl/include/alltypes.h.in#L108). Same kind of thing for the others from that block.
Member
Author
There was a problem hiding this comment.
Eventually, yes. For now though I don't think it's worth it. Currently there is no 64-bit WASI target (WebAssembly/component-model#22) so there's nothing to test against. I'm happy, however, to come around later and fix this once 64-bit targets do exist though!
Member
Author
There was a problem hiding this comment.
I like the idea of using a more representative type internally, though, so I've switched to that.
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
This commit fills out definitions in libc for rust-lang/rust#147572 notably filling out some fs-related functions as well as many pthread-related functions. The pthread-related functions were not available originally with wasi-libc but nowadays are stubs for single-threaded behavior. The goal is to make wasi targets more "unix like" in libstd and have less WASI-specific code. (backport <rust-lang#4747>) (cherry picked from commit 702efb9)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4747>) (cherry picked from commit 3fb070e)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4747>) (cherry picked from commit 06a5ca2)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
This commit fills out definitions in libc for rust-lang/rust#147572 notably filling out some fs-related functions as well as many pthread-related functions. The pthread-related functions were not available originally with wasi-libc but nowadays are stubs for single-threaded behavior. The goal is to make wasi targets more "unix like" in libstd and have less WASI-specific code. (backport <rust-lang#4747>) (cherry picked from commit 702efb9)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4747>) (cherry picked from commit 3fb070e)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4747>) (cherry picked from commit 06a5ca2)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
This commit fills out definitions in libc for rust-lang/rust#147572 notably filling out some fs-related functions as well as many pthread-related functions. The pthread-related functions were not available originally with wasi-libc but nowadays are stubs for single-threaded behavior. The goal is to make wasi targets more "unix like" in libstd and have less WASI-specific code. (backport <#4747>) (cherry picked from commit 702efb9)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fills out definitions in libc for rust-lang/rust#147572 notably filling out some fs-related functions as well as many pthread-related functions. The pthread-related functions were not available originally with wasi-libc but nowadays are stubs for single-threaded behavior. The goal is to make wasi targets more "unix like" in libstd and have less WASI-specific code.
All sources for these definitions are taken from https://github.com/WebAssembly/wasi-libc/