bsd: Add missing minherit system call#4849
Conversation
|
The |
tgross35
left a comment
There was a problem hiding this comment.
Would you be able to use mach2 instead? https://docs.rs/mach2/latest/mach2/vm_inherit/index.html. We're tryig to transition away from binding platform API like mach/ and linux/.
|
Reminder, once the PR becomes ready for a review, use |
|
@tgross35 FWIW |
|
Thanks for the links. In that case I think it’s fine here, but would you mind enabling it for those other platforms as well? At least FreeBSD and NetBSD get CI here. |
678ab86 to
8530b90
Compare
e599cd6 to
0b039e8
Compare
libc-test/semver/netbsd.txt
Outdated
| VM_INHERIT_COPY | ||
| VM_INHERIT_DONATE_COPY | ||
| VM_INHERIT_NONE | ||
| VM_INHERIT_SHARE |
There was a problem hiding this comment.
The non-Apple BSDs seem to use MAP_ as the prefix rather than VM_. I think you'll need to add those constants and update these files.
7a86c04 to
6a6f024
Compare
6a6f024 to
e6d6630
Compare
Description
Add a missing
minherit()system call and constants related to it.minherit(2) from macOS describes this call as:
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated