Open
Conversation
gibbz00
force-pushed
the
cmsg_len_space_size_t
branch
from
2e9fd25 to
c88f3c8
Compare
tgross35
added
the
stable-nominated
gibbz00
force-pushed
the
cmsg_len_space_size_t
branch
from
c88f3c8 to
9bfc5af
Compare
This comment has been minimized.
This comment has been minimized.
The original intent was to simplify the reasoning for how they differ across platforms. It should as a consequence also make it easier to extend target support. Changes: - CMSG_* functions which can be const are all marked const. - Removes unsafe from `CMSG_ALIGN`, `CMSG_SPACE`, `CMSG_LEN`. Fixes: Custom CMSG_FIRSTHDR implementation for VxWorks had missed to check that `mhdr.msg_controllen >= size_of::<cmsghdr>()`, as per POSIX 1003.1-2024. Documents: - Usage and safety requirements. - Adds missing references to upstream headers.
Fixes: rust-lang#3240 Matches all platforms except Solaris and its descendants. `size_t` is used there regardless in order to force excessive conversions, and to make cross-platform code easier to write. [illumos]: https://github.com/illumos/illumos-gate/blob/118b2dbf1f4a745a7e35a5054a777c09bd90fff7/usr/src/uts/common/sys/socket.h#L499-L505
gibbz00
force-pushed
the
cmsg_len_space_size_t
branch
from
9bfc5af to
97ccab6
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #4908
Use
size_tfor parameter and return value of CMSG_{LEN,SPACE}Fixes: #3240
Matches all platforms except Solaris and its descendants.
size_tisused there regardless in order to force excessive conversions, and to
make cross-platform code easier to write.