Open
Conversation
This comment has been minimized.
This comment has been minimized.
It's unused. `c_enum!` is now used instead.
It doesn't seem necessary. It dates back to a large commit "Let's just juggle everything around!" from the very old mega-PR rust-lang#21.
- Fix comments that incorrectly say that `Debug` is part of `extra_traits`. - Use a consistent and sensible ordering for the traits: Clone, Copy, Debug; then PartialEq, Eq, Hash. - Explain `repr` behaviour for `s_paren!`; it's different to `s!` and `s_no_extra_traits!`. - Use `$pub:vis` (instead of a hard-wired `pub`) in `s_paren!` for consistency with the other macros.
nnethercote
force-pushed
the
s
branch
2 times, most recently
from
6d82762 to
fc62e18
Compare
Contributor
|
Most of this looks good but the deprecated change seems to be causing the CI failure. Not sure if there is a good solution there. |
Contributor
|
Mind posting the before & after macro-stats if you have them handy? I'm curious about the wins. |
Author
|
I removed the commit removing the I don't have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was building rustc with
-Zmacro-stats, which drew my attention to thes!macro, and I saw some improvements could be made.