Conversation
We don't technically depend on |
|
@Thomasdezeeuw Do you feel particularly strongly about bumping our MSRV to |
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
@Thomasdezeeuw Do you feel particularly strongly about bumping our MSRV to
1.68.0? If so, I'll try a bit harder to work around it, otherwise, I think this should be good to go.
Normally I don't like to do MSRV bump in v0.x releases. That said 1.68 is from March 2023, so well over 2 years old at this point, I think it's ok to bump it.
The MSRV was explicitly bumped to 1.68.0 in rust-lang#718. This fixes the README to reflect that.
This is required by the `log` crate, bumped to 1.68.0 in rust-lang/log#718. Since such an important part of Rust infra requires 1.68.0 it's fine we bump it as well.
* chore: fix minor clippy lint in doctest * chore: bump MSRV to 1.68.0 This is required by the `log` crate, bumped to 1.68.0 in rust-lang/log#718. Since such an important part of Rust infra requires 1.68.0 it's fine we bump it as well. * deps: run cargo update * chore: update mdbook to 0.5 * chore: bump rsonpath MSRV to 1.83 * chore(test): reduce recursion depth in arbitrary filters * chore: bump rsonpath-syntax MSRV to 1.68 * chore(test): further reduce recursion depth in arbitrary filters
2 participants
This PR aims to get our CI back to green. I think we'll need to bump our MSRV to 1.68.0 to make it work, but will see if I can avoid it.