feat: impl ToValue for core::net types (Fixes #711)

[JonathanWilbur]

Fixes #711

[JonathanWilbur]

This currently isn't working. It seems that I have to make the ValueBag type support these new variants as well.

Example:

error[E0277]: the trait bound `ValueBag<'_>: From<std::net::SocketAddrV6>` is not satisfied
   --> src/kv/value.rs:388:39
    |
388 |                       Value::from_inner(value)
    |                       ----------------- ^^^^^ the trait `From<std::net::SocketAddrV6>` is not implemented for `ValueBag<'_>`
    |                       |
    |                       required by a bound introduced by this call
...

@KodrAus since you are the maintainer of the value-bag crate, would you take a PR to add variants for the core::net types, or is there a better way?

[Thomasdezeeuw]

I'm not sure about this. Where should we draw the line on what to support "natively" vs. using the fmt::Display implementation?

[KodrAus]

Since we capture types using ToValue by default, adding ToValue impls to types from the standard library seems ok to me. We can draw the line at anything that's in the standard library and has a well understood text-based format.

@JonathanWilbur for those missing From impls, I think we can just not add a by-value conversion from IpAddr to Value, and instead rely on the by-ref ToValue and From<&'_ T> conversions. Only primitive copy types like integers and booleans have by-value conversions into Value.

[KodrAus]

I don't think we should expose visitors for these types, and instead let them fall through to visit_any.

[Thomasdezeeuw]

Since we capture types using ToValue by default, adding ToValue impls to types from the standard library seems ok to me. We can draw the line at anything that's in the standard library and has a well understood text-based format.

Makes sense to me 👍